Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace push_all with extend_from_slice (and other compiler warnings fixes) #8913

Closed
craftytrickster opened this issue Dec 10, 2015 · 3 comments
Closed
Labels

Comments

@craftytrickster
Copy link
Contributor

@craftytrickster craftytrickster commented Dec 10, 2015

Compiling the latest version of servo produces several compiler warnings of the following type:

`push_all`. (several locations) This experimental fetaure has been finalized as `extend_from_slice`.
warning: use of deprecated item: renamed to extend_from_slice, #[warn(deprecated)]

canvas_traits/lib.rs:7:12: 7:16 warning: this feature is stable. attribute no longer needed, #[warn(stable_features)] on by default
canvas_traits/lib.rs:7 #![feature(core

webdriver_server/lib.rs:65:23: 65:38 warning: use of deprecated item: ip type too small a type to pull its weight, #[warn(deprecated)] on by default
webdriver_server/lib.rs:65         server::start(SocketAddr::new("0.0.0.0".parse().unwrap(), port), handler,

canvas/lib.rs:5:12: 5:16 warning: this feature is stable. attribute no longer needed, #[warn(stable_features)] on by default
canvas/lib.rs:5 #![feature(core)]

webgl_paint_task.rs:16:5: 16:35 warning: use of deprecated item: unidiomatic functions not pulling their weight, #[warn(deprecated)] on by default
webgl_paint_task.rs:16 use std::slice::bytes::copy_memory;
                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
webgl_paint_task.rs:368:13: 368:24 warning: use of deprecated item: unidiomatic functions not pulling their weight, #[warn(deprecated)] on by default
webgl_paint_task.rs:368             copy_memory(&src_slice[..stride], &mut pixels[dst_start .. dst_start + stride]);

layout/lib.rs:8:12: 8:17 warning: this feature is stable. attribute no longer needed, #[warn(stable_features)] on by default
layout/lib.rs:8 #![feature(drain)]

surface_map.rs:114:43: 114:74 warning: use of deprecated item: renamed to min_by_key, #[warn(deprecated)] on by default
surface_map.rs:114                     match self.map.iter().min_by(|&(_, x)| x.last_action) {

compositing/compositor.rs:47:5: 47:35 warning: use of deprecated item: unidiomatic functions not pulling their weight, #[warn(deprecated)] on by default
compositing/compositor.rs:47 use std::slice::bytes::copy_memory;
@alex
Copy link
Contributor

@alex alex commented Dec 11, 2015

These look to be all done.

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 11, 2015

Yep! #8922

@frewsxcv frewsxcv closed this Dec 11, 2015
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 11, 2015

Also, #8923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.