Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the slots of global objects before a possible GC. #8918

Merged
merged 1 commit into from Dec 11, 2015
Merged

Initialize the slots of global objects before a possible GC. #8918

merged 1 commit into from Dec 11, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 10, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 10, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 10, 2015

@bors-servo r=nox

@bors-servo
Copy link
Contributor

📌 Commit b353d70 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 10, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 10, 2015

@bors-servo r=nox

@bors-servo
Copy link
Contributor

📌 Commit b353d70 has been approved by nox

@KiChjang
Copy link
Contributor

Wait one second.

The Travis CI build didn't even commence - perhaps homu is having the same problem?

@bors-servo
Copy link
Contributor

⌛ Testing commit b353d70 with merge 37b6541...

bors-servo pushed a commit that referenced this pull request Dec 10, 2015
Auto merge of #8918 - Ms2ger:trace, r=nox
37b6541 
Initialize the slots of global objects before a possible GC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8918)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 10, 2015
@KiChjang
Copy link
Contributor 

Ran 3733 tests finished in 880.0 seconds.
  • 3732 ran as expected. 708 tests skipped.
  • 1 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/webgl/bufferData.html
  │ 
  │ thread 'WebGLTask' panicked at 'assertion failed: gl::get_error() == gl::NO_ERROR', /Users/servo/buildbot/slave/mac-rel-wpt/build/components/canvas/webgl_paint_task.rs:176
  │ stack backtrace:
  │    1:        0x108227e78 - sys::backtrace::tracing::imp::write::hca66179add43b2e5lLt
  │    2:        0x108229f3f - panicking::log_panic::_<closure>::closure.40842
  │    3:        0x1082299e2 - panicking::log_panic::h7a04edac7e1f2797HEx
  │    4:        0x108215726 - sys_common::unwind::begin_unwind_inner::h39a94087039ae0efnOs
  │    5:        0x1075a23c4 - sys_common::unwind::begin_unwind::begin_unwind::h4569555697223706456
  │    6:        0x1075da357 - webgl_paint_task::_<impl>::handle_webgl_message::hb2981b9ed30feedca9r
  │    7:        0x1075dcbde - sys_common::unwind::try::try_fn::try_fn::h16524033226000240316
  │    8:        0x1082272b8 - __rust_try
  │    9:        0x1082243be - sys_common::unwind::try::inner_try::h819d2da8e3dc4516VKs
  │   10:        0x1075ddc31 - boxed::_<impl>::call_box::call_box::h10948343521811825872
  │   11:        0x1082291cd - sys::thread::_<impl>::new::thread_start::h328957c252b95d3cOYw
  │   12:     0x7fff84ed8059 - _pthread_body
  │   13:    ALERT: RESULT: ["/_mozilla/mozilla/webgl/bufferData.html",0,null,null,[["bufferData and bufferSubData input array type check (issue #6791)",0,null,null]]]

@jdm
Copy link
Member

jdm commented Dec 10, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit b353d70 with merge b6da14b...

bors-servo pushed a commit that referenced this pull request Dec 10, 2015
Auto merge of #8918 - Ms2ger:trace, r=nox
b6da14b 
Initialize the slots of global objects before a possible GC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8918)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 10, 2015
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 10, 2015
@KiChjang
Copy link
Contributor 

Ran 3733 tests finished in 246.0 seconds.
  • 3732 ran as expected. 709 tests skipped.
  • 1 tests timed out unexpectedly
  • 1 tests had unexpected subtest results

Tests with unexpected results:
  ▶ TIMEOUT [expected CRASH] /workers/semantics/xhr/001.html
  │ 
  │ thread 'WebWorker for http://web-platform.test:8000/workers/semantics/xhr/001.html#' panicked at 'expected a Window scope', /home/servo/buildbot/slave/linux-rel/build/components/script/dom/bindings/global.rs:73
  │ stack backtrace:
  │    1:     0x5631fa8d1880 - sys::backtrace::tracing::imp::write::h92808652e552bec0MZt
  │    2:     0x5631fa8d46e5 - panicking::log_panic::_<closure>::closure.41184
  │    3:     0x5631fa8d4160 - panicking::log_panic::hc4038fe8a2a609d626x
  │    4:     0x5631fa8bdbe3 - sys_common::unwind::begin_unwind_inner::hd5a3cc6e3320d6b8lSs
  │    5:     0x5631f964eaef - sys_common::unwind::begin_unwind::begin_unwind::h10528527346985475295
  │    6:     0x5631f9a939f9 - dom::xmlhttprequest::_<impl>::new_doc::h3c7a40b41e9a9169mEY
  │    7:     0x5631f9a92a8c - dom::xmlhttprequest::_<impl>::handle_xml::h36b9539d653de1d2nDY
  │    8:     0x5631f98af957 - dom::xmlhttprequest::_<impl>::GetResponseXML::h99eaed5c42cbf28cfiY
  │    9:     0x5631f98af2db - dom::bindings::codegen::Bindings::XMLHttpRequestBinding::get_responseXML::h3d7d04f717088d5cGTd
  │   10:     0x5631f9fe82e6 - CallJitGetterOp
  │   11:     0x5631f968bfe7 - dom::bindings::utils::generic_call::hbcacf4900a536a849Zf
  │   12:     0x5631fa10403c - _ZN2js6InvokeEP9JSContextN2JS8CallArgsENS_14MaybeConstructE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jscntxtinlines.h:235
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:502
  │   13:     0x5631fa10552e - _ZN2js6InvokeEP9JSContextRKN2JS5ValueES5_jPS4_NS2_13MutableHandleIS3_EE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:558
  │   14:     0x5631fa108c49 - _ZN2js20InvokeGetterOrSetterEP9JSContextP8JSObjectN2JS5ValueEjPS5_NS4_13MutableHandleIS5_EE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:628
  │   15:     0x5631fa12a0f2 - _ZL10CallGetterP9JSContextN2JS6HandleIP8JSObjectEENS2_IPN2js5ShapeEEENS1_13MutableHandleINS1_5ValueEEE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:1614
  │   16:     0x5631fa149e00 - _ZN2js17NativeGetPropertyEP9JSContextN2JS6HandleIPNS_12NativeObjectEEENS3_IP8JSObjectEENS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:1664
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:1878
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:1912
  │   17:     0x5631fa110908 - _ZN2js11GetPropertyEP9JSContextN2JS6HandleIP8JSObjectEES6_NS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.h:1434
  │   18:     0x5631fa0f851b - _ZL9InterpretP9JSContextRN2js8RunStateE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:260
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:2426
  │   19:     0x5631fa103d1c - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:452
  │   20:     0x5631fa103f9d - _ZN2js6InvokeEP9JSContextN2JS8CallArgsENS_14MaybeConstructE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:521
  │   21:     0x5631fa10552e - _ZN2js6InvokeEP9JSContextRKN2JS5ValueES5_jPS4_NS2_13MutableHandleIS3_EE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:558
  └   22:     0x5631fa3cda39 - _Z20JS_CallFunctionValueP9JSContextN2JS6HandleIP8JSObjectEENS2_INS1_5ValueEEERKNS1_16HandleValueArrayENS1_13MutableHandleIS6_EE

  ▶ Unexpected subtest result in /workers/semantics/xhr/001.html:
  │ TIMEOUT [expected PASS] async XMLHttpRequest in dedicated worker
  └   → Test timed out

@jdm
Copy link
Member

jdm commented Dec 11, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit b353d70 with merge e71ec40...

bors-servo pushed a commit that referenced this pull request Dec 11, 2015
Auto merge of #8918 - Ms2ger:trace, r=nox
e71ec40 
Initialize the slots of global objects before a possible GC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8918)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 11, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit b353d70 into servo:master Dec 11, 2015
@Ms2ger Ms2ger deleted the trace branch December 18, 2015 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ms2ger @bors-servo @KiChjang @jdm @highfive