Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[meta] DevTools HTML experiment fails to load in Servo #8973
Comments
…of the child iframe of the root. Resolves servo#8973.
|
This particular iframe problem is fixed by #8978, allowing us to progress to the next set of errors :) |
Ensure that grandchild same-origin iframes are added to the children … …of the child iframe of the root. Resolves #8973. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8978) <!-- Reviewable:end -->
|
Cool! The next set of errors I'm seeing:
|
|
Should we expect contentWindow.focus() to work on an iframe? I can comment that bit out if it's not yet implemented |
|
We don't implement Window.focus() yet. |
|
@bgrins @jryans I recommend you to file one issue per bug. You can probably use this bug as a meta bug. See how we do for browser.html: browserhtml/browserhtml#562 |
jryans
changed the title
|
Okay, I've created a task list in this issue to use for tracking. Each new problem should be filed separately as it comes up, and we can use the task list to track overall progress. |
|
For the record, i think opening the devtools should be implemented at the runtime level: #7379 (comment) See Electron's code: |
|
cc @fitzgen |
The DevTools team has been working on an experimental HTML version of the Firefox DevTools UI in the joewalker/devtools.html repo. This is not something we plan to use anywhere directly, it's just an experiment to learn from for future deXULification. In any event, we thought it would be good to see how far Servo is from being able to load it. @bgrins has been working in the servo-client branch to tweak things as necessary to get something loading in Servo.
If you wish to try the experiment locally, I would suggest using Firefox as the DevTools server, and only testing the client UI in Servo to focus on this issue only. The repo's README.md explains how to get started and start a server in Firefox. So, the only modification from the README instructions would be to open the actual UI at
http://localhost:8081/client/framework/toolbox-wrapper.htmlin Servo instead.We'll use this issue to track the various individual issues as we find them:
P1
contentWindownull in frames #8978Range.getBoundingClientRectis not defined inside CodeMirror frames #8982P2
window.focusis undefined #8981@bgrins @jdm @Ms2ger @larsbergstrom