Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStyle checker: report instances of multiple spaces after a => #9042
Labels
Comments
|
I propose to take this one. |
|
Ok! |
|
Cool :-) Should I also check that we have a whitespace before and after => while I'm at it? |
|
I'm surprised we don't already, so please do! |
bors-servo
added a commit
that referenced
this issue
Dec 24, 2015
Issue #9042: Report incorrect number of spaces around => in the style checker Fixes #9042 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9055) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…round => in the style checker (from simartin:issue_9042); r=Wafflespeanut Fixes servo/servo#9042 Source-Repo: https://github.com/servo/servo Source-Revision: f77c7928868469ef4f326a269147ae2aee6151ee
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…round => in the style checker (from simartin:issue_9042); r=Wafflespeanut Fixes servo/servo#9042 Source-Repo: https://github.com/servo/servo Source-Revision: f77c7928868469ef4f326a269147ae2aee6151ee UltraBlame original commit: 600e00d6f7789a512293d716cc9f33f4528fee59
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…round => in the style checker (from simartin:issue_9042); r=Wafflespeanut Fixes servo/servo#9042 Source-Repo: https://github.com/servo/servo Source-Revision: f77c7928868469ef4f326a269147ae2aee6151ee UltraBlame original commit: 600e00d6f7789a512293d716cc9f33f4528fee59
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…round => in the style checker (from simartin:issue_9042); r=Wafflespeanut Fixes servo/servo#9042 Source-Repo: https://github.com/servo/servo Source-Revision: f77c7928868469ef4f326a269147ae2aee6151ee UltraBlame original commit: 600e00d6f7789a512293d716cc9f33f4528fee59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've seen this in a couple PRs, and it's an easy thing to check for (
"=> ") (note: markdown collapses two spaces into one in the previous code fragment). We should add it to our syntax lints and fix any instances reported by./mach test-tidy.Code: python/tidy.py