Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic loading http://people.mozilla.org/~sicking/webgl/ray.html #9097

Closed
simartin opened this issue Dec 30, 2015 · 2 comments
Closed

Panic loading http://people.mozilla.org/~sicking/webgl/ray.html #9097

simartin opened this issue Dec 30, 2015 · 2 comments

Comments

@simartin
Copy link
Contributor

@simartin simartin commented Dec 30, 2015

This is to track the case reported by @dzbarsky in #8741, a different issue from the initial one

I've started to work on it and I believe the issue is we might not implement the "Automatic assignment" part of https://www.opengl.org/wiki/Vertex_Shader#Inputs

I'll continue to investigate, so feel free to assign the issue directly to me.

@simartin
Copy link
Contributor Author

@simartin simartin commented Dec 30, 2015

The issue is not linked to the missing "Automatic assignment" as I thought (I checked and Chrome does not do it...), but rather to the fact that we were blindly calling xyVertexAttribxy without checking the index we passed. This will generate a InvalidValue GL error if it's above MAX_VERTEX_ATTRIBS, in particular when it's -1, coming from a call to getAttribLocation for some unbound attribute.

@jdm
Copy link
Member

@jdm jdm commented Aug 25, 2016

Fixed by #10224.

@jdm jdm closed this Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.