Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing enumerated attributes as atoms #9101

Open
jdm opened this issue Dec 30, 2015 · 3 comments
Open

Consider storing enumerated attributes as atoms #9101

jdm opened this issue Dec 30, 2015 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 30, 2015

@nox's position is that the current representation wastes spaces and performs worse than storing an Atom. I haven't put any thought into the matter.

@nox
Copy link
Member

@nox nox commented Dec 30, 2015

This was prompted by #9100. Note that all the related button types in that case are short, and would be all inline even if not in the atom global static table. They should anyway because we want to use them as patterns in attribute_mutated.

@nox
Copy link
Member

@nox nox commented Jan 3, 2016

As stated in #9132, <input> already use atoms for its type attribute value.

@nox
Copy link
Member

@nox nox commented Mar 4, 2017

We now do this pretty consistently, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.