Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for 'input' event for <input> elements #9131

Open
frewsxcv opened this issue Jan 2, 2016 · 5 comments
Open

Add integration test for 'input' event for <input> elements #9131

frewsxcv opened this issue Jan 2, 2016 · 5 comments

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 2, 2016

#9122 merged without any regression tests.

@frewsxcv frewsxcv changed the title Add unit test for 'input' event for <input> elements Add integration test for 'input' event for <input> elements Jan 2, 2016
@chkimes
Copy link
Contributor

@chkimes chkimes commented Jan 2, 2016

I'd like to handle this one since I wrote #9122, but I'm unfamiliar with the servo test setup and not sure where to start. Are there some existing tests for events or key press handling that I can use as a reference?

@nox
Copy link
Member

@nox nox commented Jan 2, 2016

@frewsxcv Ew, I'm blind. Sorry for this.

@KiChjang KiChjang added the C-assigned label Jan 3, 2016
@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Jan 3, 2016

@ckimes89: @nox and I just briefly discussed this on IRC. Considering the input event only gets triggered when the user modifies the value of an <input> element, we might need to wait until we have all the WebDriver commands implemented (#8623). WebDriver is a testing framework similar to Selenium that simulates user interaction

@chkimes
Copy link
Contributor

@chkimes chkimes commented Mar 7, 2016

@frewsxcv @nox It looks like Element Send Keys from WebDriver is already implemented which I think is the only thing needed to test the input event. However, I'm not sure how to use WebDriver in the test suite, are there any examples for this?.

@jdm
Copy link
Member

@jdm jdm commented Mar 7, 2016

Unfortunately not. That is part of an ongoing project that will hopefully yield useful results to build on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.