Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTMLDetailsElement #9216
Comments
|
This one is appealing me. May I give it a try ? I understand #9217 is blocking it, but I expect it to be reviewed before I even get rid of
while trying to build. |
|
As for that error, take a look at components/script/dom/mod.rs :) |
|
This module screams "have mercy and codegen the hell out of myself" to me. |
|
Thanks. :) |
|
The details element should hide non "first-child I was wondering how this is supposed to be implemented, and if it is in the scope of the issue ? Also, user agent should provide a way to toggle the details element, but this is a design decision and goes way beyond just implementing the HTMLDetailsElement interface. ATM, on my working copy, the only way is setting the open attribute via JS. |
|
Yes, we should file a separate issue about exposing a UI for |
Implement HTMLDetailsElement. Fixes #9216 Implement the interface HTMLDetailsElement ( // https://html.spec.whatwg.org/multipage/#htmldetailselement ) All tests pass in tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/details.html & tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html Anyway, no change is made on layout and attribute open currently has no effect, it just fires a toggle event. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9381) <!-- Reviewable:end -->
Implement HTMLDetailsElement. Fixes #9216 Implement the interface HTMLDetailsElement ( // https://html.spec.whatwg.org/multipage/#htmldetailselement ) All tests pass in tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/details.html & tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html Anyway, no change is made on layout and attribute open currently has no effect, it just fires a toggle event. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9381) <!-- Reviewable:end -->
This requires an implementation of the
attribute_mutatedfunction inVirtualMethodsforHTMLDetailsElement, when attempting to implement the details notification task steps. It also requires the usage of the DOM manipulation task source.Code:
components/script/dom/htmldetailselement.rs(new file),components/script/dom/webidls/HTMLDetailsElement.webidl(new file)Tests:
tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/details.htmlSpec: https://html.spec.whatwg.org/multipage/#htmldetailselement
Requires #9217.