Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MozBrowserEvent to script_traits #9225

Closed
jdm opened this issue Jan 9, 2016 · 7 comments
Closed

Move MozBrowserEvent to script_traits #9225

jdm opened this issue Jan 9, 2016 · 7 comments
Labels
C-assigned E-easy I-refactor

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 9, 2016

It's defined in msg but only used by compositing, script, and script_traits. It belongs in script_traits.

Code: components/msg/constellation_msg.rs, components/script_traits/lib.rs
@apopiak
Copy link
Contributor

@apopiak apopiak commented Jan 11, 2016

I'd like to grab this one.
@jdm would you be willing to mentor? (newbie here ;-) )
@KiChjang KiChjang added the C-assigned label Jan 11, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 11, 2016

Again, look for us in the IRC channel :)
@jdm
Copy link
Member Author

@jdm jdm commented Jan 11, 2016

@apopiak Absolutely!
@apopiak
Copy link
Contributor

@apopiak apopiak commented Jan 11, 2016

claiming this one then :-) (as well)
@jdm jdm mentioned this issue Jan 11, 2016
Merged
@apopiak
Copy link
Contributor

@apopiak apopiak commented Jan 12, 2016

so @bholley
this one is still open? ;-)
@apopiak apopiak mentioned this issue Jan 12, 2016
Merged
@bholley
Copy link
Contributor

@bholley bholley commented Jan 12, 2016

As far as I know yes! Double-check with @jdm or @KiChjang or @nox on IRC to be sure.
@nox
Copy link
Member

@nox nox commented Jan 12, 2016

@apopiak Yes it is.
bors-servo added a commit that referenced this issue Jan 12, 2016
@bors-servo
Auto merge of #9271 - apopiak:moveMozBrowserEvent_9225, r=KiChjang
8590779 
Move `MozBrowserEvent` to `script_traits`

close #9225

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9271)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 13, 2016
@bors-servo
Auto merge of #9271 - apopiak:moveMozBrowserEvent_9225, r=KiChjang
Loading status checks…
897007f 
Move `MozBrowserEvent` to `script_traits`

close #9225

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9271)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Move `MozBrowserEvent` to `script_traits`
5 participants
@jdm @nox @bholley @KiChjang @apopiak
You can’t perform that action at this time.