Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font (fallback) glyph shaping callbacks should handle multiple glyphs per char #93

Closed
burg opened this issue Oct 5, 2012 · 1 comment
Closed

Comments

@burg
Copy link

@burg burg commented Oct 5, 2012

The callbacks should support returning multiple glyph indexes and advances per unicode char. Right now the return values are clipped to a single glyph/advance value.

When harfbuzz can't do its own mapping from unicode codepoints to font glyphs (perhaps the font is not SFNT format), it uses callbacks of the Font trait (glyph_h_advance and glyph_index).

I don't think we should be using these in the fast path, since harfbuzz can do its own mappings. They will be necessary for webfonts though, which may not be in a harfbuzz-friendly format.

@burg
Copy link
Author

@burg burg commented Nov 16, 2012

It looks like Gecko does the mapping itself, unless the Font subclass claims it can do a better job. This case only seems to happen for FT2. Closing until there's a reason to not punt to CoreText.

@burg burg closed this Nov 16, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Clip colors, and introduce a fast path for axis-aligned linear gradients.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.