Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement console#time and console#timeEnd methods #9325

Closed
frewsxcv opened this issue Jan 14, 2016 · 7 comments
Closed

Implement console#time and console#timeEnd methods #9325

frewsxcv opened this issue Jan 14, 2016 · 7 comments
Labels
A-devtools C-assigned

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 14, 2016

https://developer.mozilla.org/en-US/docs/Web/API/Console#Timers

An effort to implement this was started in #6646, but wasn't completed
@frewsxcv frewsxcv added the A-devtools label Jan 14, 2016
@frewsxcv frewsxcv mentioned this issue Jan 14, 2016
Closed
@shssoichiro
Copy link
Contributor

@shssoichiro shssoichiro commented Jan 23, 2016

I'd like to work on this, since no one has claimed it yet.
@KiChjang KiChjang added the C-assigned label Jan 23, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 23, 2016

Alright!
@shssoichiro
Copy link
Contributor

@shssoichiro shssoichiro commented Jan 24, 2016

Are there tests implemented for the other console methods? (And if so, where are they located?)
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jan 25, 2016

Are there tests implemented for the other console methods?

I don't think so.
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jan 25, 2016

Maybe you can create a new directory: tests/wpt/mozilla/tests/mozilla/console or tests/wpt/mozilla/tests/mozilla/devtools
@jdm
Copy link
Member

@jdm jdm commented Jan 25, 2016

There is no way to write a WPT test for console methods, unfortunately (since their effects are not observable by web content). We also can't write tests for the console integration with the devtools server until #5971 is complete, so only manual testing is possible right now.
@shssoichiro shssoichiro mentioned this issue Jan 25, 2016
Merged
@shssoichiro
Copy link
Contributor

@shssoichiro shssoichiro commented Jan 25, 2016

All right. I didn't worry about writing WPT tests for now and just did manual testing.

In the early return cases, I was unsure if we wanted to log this with println! or display any sort of message to the user (behavior in these cases is undocumented). I left these cases empty for now.
bors-servo added a commit that referenced this issue Jan 29, 2016
@bors-servo
Auto merge of #9420 - shssoichiro:console-time, r=KiChjang
74573fd 
Implement console#time and console#timeEnd methods

Fixes #9325

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9420)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 29, 2016
@bors-servo
Auto merge of #9420 - shssoichiro:console-time, r=KiChjang
Loading status checks…
dc223eb 
Implement console#time and console#timeEnd methods

Fixes #9325

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9420)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devtools C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @paulrouget @frewsxcv @KiChjang @shssoichiro
You can’t perform that action at this time.