Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable webgl conformance tests #9331

Closed
Ms2ger opened this issue Jan 15, 2016 · 2 comments
Closed

Enable webgl conformance tests #9331

Ms2ger opened this issue Jan 15, 2016 · 2 comments
Labels
A-testing

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jan 15, 2016

They're not particularly stable right now, and I want to land #9313 before investigating.
@frewsxcv frewsxcv added the A-testing label Jan 15, 2016
anholt added a commit to anholt/servo that referenced this issue Aug 10, 2016
@anholt
Disable expected-crash state of many WebGL tests on Linux.
46b0754 
These tests are still all skipped currently (see servo#9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).
anholt added a commit to anholt/servo that referenced this issue Aug 10, 2016
@anholt
Remove expected-crash state of many WebGL tests on Linux.
1caf82b 
These tests are still all skipped currently (see servo#9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).
@anholt anholt mentioned this issue Aug 10, 2016
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Aug 10, 2016
@bors-servo
Auto merge of #12793 - anholt:webgl-linux-expected-update, r=emilio
Loading status checks…
a191bd4 
Remove expected-crash state of many WebGL tests on Linux.

<!-- Please describe your changes on the following line: -->

Clear the expected-crash state on some webgl tests on linux, to reduce the diff necessary when enabling webgl testing on Linux again.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the changes are to test expectations.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

These tests are still all skipped currently (see #9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12793)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 10, 2016
@bors-servo
Auto merge of #12793 - anholt:webgl-linux-expected-update, r=emilio
Loading status checks…
c726eb3 
Remove expected-crash state of many WebGL tests on Linux.

<!-- Please describe your changes on the following line: -->

Clear the expected-crash state on some webgl tests on linux, to reduce the diff necessary when enabling webgl testing on Linux again.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the changes are to test expectations.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

These tests are still all skipped currently (see #9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12793)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 14, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
60a44d8 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
@anholt anholt mentioned this issue Aug 14, 2016
Closed
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Aug 14, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
12f7c70 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 14, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
acbdc00 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 14, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
10bf9e5 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 14, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
af99035 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 14, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
58c909d 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 14, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
52ab3f4 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 14, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
08899a2 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 15, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
f8763f4 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 15, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=emilio
Loading status checks…
1fb783f 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 15, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
7f1c3ca 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 15, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=emilio
Loading status checks…
1c3bcfb 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 16, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
8a70c0f 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 20, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
5df6cc2 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 20, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
aa72171 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 20, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=<try>
Loading status checks…
22742ba 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 21, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
549c0c1 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 21, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=emilio
Loading status checks…
f106f40 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
anholt added a commit to anholt/servo that referenced this issue Aug 22, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
ca06388 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
anholt added a commit to anholt/servo that referenced this issue Aug 22, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
5782d7a 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
anholt added a commit to anholt/servo that referenced this issue Aug 22, 2016
@anholt
wpt: Re-enable the webgl tests on Linux.
a0b738d 
From a conversation on #servo:

<Manishearth> Ms2ger: why are they disabled on linux only?
<Ms2ger> Don't recall
<Ms2ger> Probably builder issues

Fixes servo#9331
bors-servo added a commit that referenced this issue Aug 22, 2016
@bors-servo
Auto merge of #12858 - anholt:webgl-enable-tests-linux, r=emilio
Loading status checks…
8491c09 
Enable wpt WebGL tests on Linux

<!-- Please describe your changes on the following line: -->

Enables the WebGL tests in test-wpt on Linux.  They have been disabled since the webgl conformance tests first showed up, and it looks like they should work now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9331

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12858)
<!-- Reviewable:end -->
samuknet added a commit to samuknet/servo that referenced this issue Sep 6, 2016
@anholt @samuknet
Remove expected-crash state of many WebGL tests on Linux.
c4ff001 
These tests are still all skipped currently (see servo#9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).
@nox
Copy link
Member

@nox nox commented Sep 30, 2017

These were enabled, right @emilio?
@jdm
Copy link
Member

@jdm jdm commented Sep 30, 2017

Yes.
@jdm jdm closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Enable wpt WebGL tests on Linux
4 participants
@jdm @Ms2ger @nox @frewsxcv
You can’t perform that action at this time.