Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade servo-glutin to latest published version (0.4.7) #9339

Merged
merged 1 commit into from Jan 18, 2016

Conversation

frewsxcv
Copy link
Contributor

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

AltF02/x11-rs#32

...which results in two fewer libc 0.1.x dependency

#8608

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 16, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 18f2da8 with merge 9ebd0fa...

bors-servo pushed a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 16, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo retry

#9286

@bors-servo
Copy link
Contributor

⌛ Trying commit 18f2da8 with merge 6c392d1...

bors-servo pushed a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 16, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo retry

#9286

@bors-servo
Copy link
Contributor

⌛ Trying commit 18f2da8 with merge 29faf15...

bors-servo pushed a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 16, 2016
@bors-servo
Copy link
Contributor

⌛ Trying commit 18f2da8 with merge c3d6acc...

bors-servo pushed a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 16, 2016
@emilio
Copy link
Member

emilio commented Jan 16, 2016

There was a problem updating to the latest glutin (see #9115).

I actually have a computer that can reproduce it, so I'll take a look at it, but I don't think we should update glutin until that gets solved.

@emilio
Copy link
Member

emilio commented Jan 16, 2016

@frewsxcv
Copy link
Contributor Author

cc @SimonSapin

@frewsxcv
Copy link
Contributor Author

This is now blocked on servo/glutin#62

@frewsxcv frewsxcv added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Jan 16, 2016
@frewsxcv
Copy link
Contributor Author

Reminder to myself to update the commit message of this commit to mention the x11-dl update which gets rid of another libc 0.1.x dep

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

AltF02/x11-rs#32

...which results in two fewer libc 0.1.x dependency

servo#8608
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jan 16, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo try

@frewsxcv frewsxcv removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Jan 16, 2016
@frewsxcv frewsxcv changed the title Upgrade servo-glutin to latest published version (0.4.6) Upgrade servo-glutin to latest published version (0.4.7) Jan 16, 2016
@nox
Copy link
Contributor

nox commented Jan 16, 2016

RIP Homu.

http://build.servo.org/waterfall

@emilio
Copy link
Member

emilio commented Jan 17, 2016

@bors-servo: try (it seems to be up again)

@frewsxcv there are still libc 1.x deps, right? If there aren't we could remove libc from the dependency check that tidy does.

@emilio
Copy link
Member

emilio commented Jan 17, 2016

@bors-servo try

@SimonSapin
Copy link
Member

According to components/servo/Cargo.lock in this branch, libc 0.1 still has two dependents: malloc_buf and objc-foundation.

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 18f2da8 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 17, 2016
@frewsxcv frewsxcv closed this Jan 18, 2016
@frewsxcv frewsxcv reopened this Jan 18, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit f5c6c60 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit f5c6c60 with merge 6b81a72...

bors-servo pushed a commit that referenced this pull request Jan 18, 2016
Upgrade servo-glutin to latest published version (0.4.7)

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

AltF02/x11-rs#32

...which results in two fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 18, 2016
@frewsxcv
Copy link
Contributor Author

@bors-servo retry #9163

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit f5c6c60 into servo:master Jan 18, 2016
@frewsxcv frewsxcv deleted the bump-glutin branch January 18, 2016 04:59
@SimonSapin SimonSapin removed the S-tests-failed The changes caused existing tests to fail. label Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants