New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build fails with a space in the pathname #9442
Comments
@UK992 Hrm, I haven't seen this before! Are you running CC'ing @Jayflux and @adamncasey in case they've seen this before. |
@larsbergstrom Any chance you have a local cargo override for skia that didn't end up getting published? |
@jdm Nope, everything's clean & committed and we've verified on multiple other machines (jay, adam, and vlad). |
@larsbergstrom yes, i used MINGW64. |
I haven't seen that error before. Strange. I'm building in |
@UK992 does |
@larsbergstrom It have spaces. |
Just tried building servo in a directory with spaces and I got an error as well, though a different error.
|
I think we should probably have |
I removed spaces from username and is now a successfully build Servo in |
Can this issue be closed? Or do we still need a patch for |
@KiChjang Yeah, I'd like to see a patch that fixes that issue. I've edited the issue. The work here is to have |
Relevant code: |
Relying on access to a path with spaces is not a good idea on Windows, where usernames often have spaces. I think that |
@drbo Certainly, I'd be open to another (definitely not |
I'd like to give this a try, if no one else is working on this. |
Go for it! |
Exit mach with an error when building on a path with spaces. Fixes #9442 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9601) <!-- Reviewable:end -->
By default, at least to my understanding, usernames on Win10 are just firstname + space + lastname, so "just hope there's not space in the username" doesn't seem like a reasonable approach to this problem. |
I can't build Servo on Windows 10, keep throwing this error:
The text was updated successfully, but these errors were encountered: