Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate the canvas webidl to match the spec #9443
Comments
|
Looking to get involved, this would be my first contribution to open source anything,ever. Don't really know where to start so a welcome shove off the correct cliff would be appreciated, I'll find a parachute on the way down. On a side note I've been have some issues compiling the source :
Done a fair bit of googling but haven't really been able to find much. |
|
@J2R5M3 Welcome! It appears you're missing a dependency, and presumably you're not on a debian-based linux as that would be covered by the "libegl1-mesa-dev" in README.md. You may want to try installing "mesa-libEGL-devel" if you're on Fedora? Hard to give better suggestions without more information. As for how to get started, this is really about cleaning up the contents of the webidl file I linked in the original description to match the WebIDL interfaces that are present in the specification that's also linked previously. Does that help at all? |
|
mostly, just was wondering about any sources I could reference regarding which features are supported and which aren't |
|
All I can recommend is to use the existing webidl files as reference (ie. note what is already commented out). |
|
Has this bug been claimed? |
|
I've been kinda swamped with a wave of assignments for school and work, if you want to lend a hand or even take over that's perfectly fine with me, I had hoped to get involved but it is the case that my current schedule can't handle anything additional right now at least for the next 4-5 days, priorities and such. |
|
@J2R5M3 I'm happy to let you take care of it. Should it be marked assigned? |
|
Okay, just let us know of any updates! @J2R5M3 |
|
This has been left idle for about a month and I would like to try fixing it. Any objections? |
|
I believe that I already have an implementation of it (though it is about a month old now). I can update it to the latest code and see if it still works. |
|
Okay, never mind then. :) Let me know if anything changes @gmalecha |
…, r=jdm updating the CanvasRenderingContext2D to match the spec - fixes #9443 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9823) <!-- Reviewable:end -->
…, r=jdm updating the CanvasRenderingContext2D to match the spec - fixes #9443 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9823) <!-- Reviewable:end -->
Our
CanvasRenderingContext2D.webidlis based on an older revision before the spec started grouping related APIs together in different interfaces. We should update it to match the spec more closely. There should be no functional change and everything should keep compiling exactly as it does today. Some features likeExposed=(Window,Worker)will need to be commented out because we don't support them yet.Code:
components/script/dom/webidls/CanvasRenderingContext2D.webidlSpec: https://html.spec.whatwg.org/multipage/scripting.html#2dcontext