Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On OSX, fonts are lighter than gecko and webkit #9487

Closed
paulrouget opened this issue Feb 1, 2016 · 3 comments
Closed

On OSX, fonts are lighter than gecko and webkit #9487

paulrouget opened this issue Feb 1, 2016 · 3 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 1, 2016

screen shot 2016-02-01 at 12 07 54

<span>FOOBAR</span>
<style>
  span {
    font-size: 14px;
    font-family: sans-serif;
  }
</style>

I haven't tested on other platforms.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Apr 13, 2016

Attempt to bump the priority of this.

Do we know what's going on? Is it hard to fix?
If it's easy, I'd love to get that done by June. It would make our UI look exactly like gecko and webkit (and I haven't found any CSS workaround to fix that)

If it's too much work - let's flag it back to P3.

@glennw
Copy link
Member

@glennw glennw commented Apr 13, 2016

@paulrouget I believe there's two issues here - one is our actual font selection matching is different than Gecko, and two is the lack of subpixel AA. I'm hoping to have a solution for the 2nd issue before June. The first issue should be (relatively) trivial to implement - if someone with mac experience has time to look into it.

@glennw
Copy link
Member

@glennw glennw commented Apr 13, 2016

Of course, getting the font selection to exactly match gecko is far from trivial, but fixing the common case shouldn't be too difficult hopefully.

pcwalton added a commit to pcwalton/servo that referenced this issue Apr 30, 2016
This matches what I believe the OS native defaults to be.

Partially addresses servo#9487.
bors-servo added a commit that referenced this issue May 1, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue May 2, 2016
Roboto on Android.

This matches what I believe the OS native defaults to be.

Partially addresses servo#9487.
bors-servo added a commit that referenced this issue May 3, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue May 4, 2016
Roboto on Android.

This matches what I believe the OS native defaults to be.

Partially addresses servo#9487.
bors-servo added a commit that referenced this issue May 4, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 5, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 6, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 6, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 6, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue May 9, 2016
Roboto on Android.

This matches what I believe the OS native defaults to be.

Partially addresses servo#9487.
bors-servo added a commit that referenced this issue May 9, 2016
gfx: Map `sans-serif` to Helvetica on Mac and DejaVu Sans on Linux.

This matches what I believe the OS native defaults to be.

Partially addresses #9487.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10937)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue May 9, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue May 9, 2016
-> [100, 900] to [-1.0, 1.0] -> [100, 700].

CSS `normal` font-weight is specified as 400, while Mac "Regular" font
weight is reported as 0.0. On the Mac, we need to center the two ranges
on the same value to avoid choosing "Light" fonts where "Regular" would
have been more appropriate.

Closes servo#9487.
pcwalton added a commit to pcwalton/servo that referenced this issue May 10, 2016
to 400, not 500.

CSS `normal` font-weight is specified as 400, while Mac "Regular" font
weight is reported as 0.0. On the Mac, we need to center the two ranges
on the same value to avoid choosing "Light" fonts where "Regular" would
have been more appropriate.

Closes servo#9487.

fix for mac
bors-servo added a commit that referenced this issue May 10, 2016
gfx: Map CSS `normal` font weight to Regular font weight on the Mac.

This series of commits fixes #9487, and improves the look of nytimes.com among others.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 10, 2016
gfx: Map CSS `normal` font weight to Regular font weight on the Mac.

This series of commits fixes #9487, and improves the look of nytimes.com among others.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue May 10, 2016
pcwalton added a commit to pcwalton/servo that referenced this issue May 10, 2016
to 400, not 500.

CSS `normal` font-weight is specified as 400, while Mac "Regular" font
weight is reported as 0.0. On the Mac, we need to center the two ranges
on the same value to avoid choosing "Light" fonts where "Regular" would
have been more appropriate.

Closes servo#9487.

fix for mac
bors-servo added a commit that referenced this issue May 10, 2016
gfx: Map CSS `normal` font weight to Regular font weight on the Mac.

This series of commits fixes #9487, and improves the look of nytimes.com among others.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 10, 2016
gfx: Map CSS `normal` font weight to Regular font weight on the Mac.

This series of commits fixes #9487, and improves the look of nytimes.com among others.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11103)
<!-- Reviewable:end -->
zakorgy added a commit to zakorgy/servo that referenced this issue May 26, 2016
Roboto on Android.

This matches what I believe the OS native defaults to be.

Partially addresses servo#9487.
zakorgy added a commit to zakorgy/servo that referenced this issue May 26, 2016
zakorgy added a commit to zakorgy/servo that referenced this issue May 26, 2016
to 400, not 500.

CSS `normal` font-weight is specified as 400, while Mac "Regular" font
weight is reported as 0.0. On the Mac, we need to center the two ranges
on the same value to avoid choosing "Light" fonts where "Regular" would
have been more appropriate.

Closes servo#9487.

fix for mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.