Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThe gold linker should not be used on Windows #9499
Comments
|
@larsbergstrom This seems difficult to get right! |
|
@jdm Agreed :-) Though a large part of it is also that we don't have CI up yet for all of our platforms. While I can say I should certainly know better, as we expand our platform matrix, it's pretty unreasonable to expect every reviewer to know the impact of small python changes on, say, the AARCH64 cross-build. |
|
The change required here is that the python code that chooses to use the gold linker: servo/python/servo/command_base.py Line 382 in 220ead1 Should not do so if the |
|
@larsbergstrom in MINGW64 shell, sys.platform return 'msys', not 'win32'. |
|
So would we check both msys and win32? |
add check for win32 or msys before running rustc-with-gold fixes #9499 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9588) <!-- Reviewable:end -->
After #9449 building on Windows failed: