Beautify our union enums constructors

[nox]

They should be NodeOrString::Node instead of NodeOrString::eNode.

Files:

• components/script/dom/bindings/codegen/CodegenRust.py

[jdm]

Specifically, CGUnionStruct is the python class that defines this.

[alopatindev]

Anyone mind if I pick this up?

The change should be probably something like that

diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/Co
degenRust.py
index 8d53913..c4cc86a 100644
--- a/components/script/dom/bindings/codegen/CodegenRust.py
+++ b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -3636,10 +3636,10 @@ class CGUnionStruct(CGThing):
         templateVars = map(lambda t: getUnionTypeTemplateVars(t, self.descriptorProvider),
                            self.type.flatMemberTypes)
         enumValues = [
-            "    e%s(%s)," % (v["name"], v["typeName"]) for v in templateVars
+            "    %s(%s)," % (v["name"], v["typeName"]) for v in templateVars
         ]
         enumConversions = [
-            "            %s::e%s(ref inner) => inner.to_jsval(cx, rval),"
+            "            %s::%s(ref inner) => inner.to_jsval(cx, rval),"
             % (self.type, v["name"]) for v in templateVars
         ]
         return ("""\

But after the change I've got compilation errors related to enums that are used in components/script/dom.

error: no associated item named `eHTMLCanvasElement` found for type `dom::bindings::codegen::UnionTypes::ImageDataOrHTMLImageElementOrHTMLCanvasElementOrHTMLVideoElement` in the current scope servo/components/script/dom/webglrenderingcontext.rs:1160

Should the files in components/script/dom be regenerated (How if so? I didn't figure out from the docs) or changed manually?

Thanks!

[jdm]

Everything under components is written by hand.