Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html #9550

Closed
nox opened this issue Feb 5, 2016 · 1 comment
Closed

Intermittent FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html #9550

nox opened this issue Feb 5, 2016 · 1 comment
Assignees
@mbrubeck
Labels
I-intermittent

Comments

@nox
Copy link
Member

@nox nox commented Feb 5, 2016 

Tests with unexpected results:
  ▶ FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html
  └   → /_mozilla/css/filter_opacity_a.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
/_mozilla/css/filter_opacity_ref.html 8c0e24e2815907250cea7f66afb2a7ac90120320
Testing d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c == 8c0e24e2815907250cea7f66afb2a7ac90120320
@nox nox added the I-intermittent label Feb 5, 2016
@nox nox mentioned this issue Feb 5, 2016
Merged
@jdm jdm mentioned this issue Feb 17, 2016
Merged
@KiChjang KiChjang mentioned this issue Feb 25, 2016
Merged
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Feb 25, 2016

In #9743 (comment) the failure was opposite:

  ▶ FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html
  └   → /_mozilla/css/filter_opacity_a.html 8c0e24e2815907250cea7f66afb2a7ac90120320
/_mozilla/css/filter_opacity_ref.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
Testing 8c0e24e2815907250cea7f66afb2a7ac90120320 == d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c

In some cases the test file renders all white; in other cases the reference file renders all white.

This started right after #9503 landed, which affects opacity, though that should only affect text nodes. It seems more likely this is related to image loading. Maybe #9208 which also landed around the right time?
@mbrubeck mbrubeck changed the title FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html Intermittent FAIL [expected PASS] /_mozilla/css/filter_opacity_a.html Feb 25, 2016
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
6ff9818 
Fixes servo#9550.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
d07a684 
Fixes servo#9550.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
360c61e 
Fixes servo#9550.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
f08e3fd 
PR servo#9208 added the ability to perform layout before an `<img>` resource is
fully loaded. However, when we are rendering to an image file for testing
purposes, we need to block until the image content is fully loaded (until
issue servo#9441 is fixed).

Fixes servo#9550.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
fa22bf2 
PR servo#9208 added the ability to perform layout before an `<img>` resource is
fully loaded. However, when we are rendering to an image file for testing
purposes, we need to block until the image content is fully loaded (until
issue servo#9441 is fixed).

Fixes servo#9550.
@mbrubeck mbrubeck mentioned this issue Feb 25, 2016
Merged
mbrubeck added a commit to mbrubeck/servo that referenced this issue Feb 25, 2016
@mbrubeck
Don't use image metadata for layout when rendering to a file
37dd2a6 
PR servo#9208 added the ability to perform layout before an `<img>` resource is
fully loaded. However, when we are rendering to an image file for testing
purposes, we need to block until the image content is fully loaded (until
issue servo#9441 is fixed).

Fixes servo#9550.
bors-servo added a commit that referenced this issue Feb 25, 2016
@bors-servo
Auto merge of #9754 - mbrubeck:img-metadata, r=jdm
Loading status checks…
21f0e63 
Don't use image metadata for layout when rendering to a file

Fixes #9550. r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9754)
<!-- Reviewable:end -->
@mbrubeck mbrubeck self-assigned this Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
I-intermittent
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Don't use image metadata for layout when rendering to a file
2 participants
@mbrubeck @nox
You can’t perform that action at this time.