No load blocker created when iframe.reload() is used

[jdm]

There's no URL present, so we can't create a load blocker. We should fix this by making sure the iframe is always aware of the url of the currently framed document.
#6677

[cbrewster]

@asajeffrey is it possible to do this now? or do we need to manually track the current url?

[atouchet]

@gterzian did #23368 address this?

[gterzian]

@gterzian did #23368 address this?

It did not address it, at least not in so far as I am aware of.

Could also relate to #23760

Another related issue I think is #22879, because an about:blank iframe should in fact have the origin of it's parent, I think, while currently we give it an opaque origin by default, I think.

So while Url and Origin aren't the same thing, I think this is a symptom of a larger problem with how we deal with document origins.

See https://html.spec.whatwg.org/multipage/browsers.html#determining-the-origin

Which is actually a new algorithm, meaning that also relevant is #23759

So maybe the way to do this is to focus on #23759, and deal with this as part of it?

[gterzian]

Hang-on, somehow it either did or I removed the comment in error at https://github.com/servo/servo/pull/23368/files#diff-498ce74d806ab54484e768d9237a53b1L149

[gterzian]

Ok so yes the LoadData is not optional anymore, so this is "fixed" https://github.com/servo/servo/pull/23368/files#diff-498ce74d806ab54484e768d9237a53b1R112

So I removed with Option around LoadData, and that's because it was never called with None. So it seems like the comment was invalid, and this issue fixed in an earlier change, since it was about dealing with the already non-existent None case.

Unless I'm missing something...

[gterzian]

This was the historical case where None was used:

https://github.com/jdm/servo/blob/c5fe8f74010a872e1b0a2f5d7f956c679fc08855/components/script/dom/htmliframeelement.rs#L459

[jdm]

As written, the problem described in this issue looks fixed, in that case.