Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various canvas properties to use enums instead of DOMString #9617

Closed
jdm opened this issue Feb 12, 2016 · 2 comments
Closed

Update various canvas properties to use enums instead of DOMString #9617

jdm opened this issue Feb 12, 2016 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 12, 2016

whatwg/html@a4b9eef was merged into the HTML spec, so we should update our Canvas WebIDL declarations to match it.

Spec: https://html.spec.whatwg.org/multipage/scripting.html#canvaslinecap
Code: components/script/dom/webidls/Canvas2dRenderingContext.webidl, components/script/dom/canvasrenderingcontext2d.rs

@saurvs
Copy link
Contributor

@saurvs saurvs commented Feb 18, 2016

I'd like to give this a try.

@jdm
Copy link
Member Author

@jdm jdm commented Feb 18, 2016

@saurvs Go for it!

@jdm jdm added the C-assigned label Feb 18, 2016
bors-servo added a commit that referenced this issue Feb 19, 2016
Update some canvas properties as enums instead of DOMString

Fixes #9617

I'm going to incrementally rollout commits and squash them finally.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9689)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 19, 2016
Update some canvas properties as enums instead of DOMString

Fixes #9617

I'm going to incrementally rollout commits and squash them finally.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9689)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…f DOMString (from saurvs:master); r=jdm

Fixes servo/servo#9617

I'm going to incrementally rollout commits and squash them finally.

Source-Repo: https://github.com/servo/servo
Source-Revision: c68fbee03ecc0054205b7f58ce232cd844eee578

UltraBlame original commit: 6f05409282886dfd20953c11cce41577aa106d1f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…f DOMString (from saurvs:master); r=jdm

Fixes servo/servo#9617

I'm going to incrementally rollout commits and squash them finally.

Source-Repo: https://github.com/servo/servo
Source-Revision: c68fbee03ecc0054205b7f58ce232cd844eee578

UltraBlame original commit: 6f05409282886dfd20953c11cce41577aa106d1f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…f DOMString (from saurvs:master); r=jdm

Fixes servo/servo#9617

I'm going to incrementally rollout commits and squash them finally.

Source-Repo: https://github.com/servo/servo
Source-Revision: c68fbee03ecc0054205b7f58ce232cd844eee578

UltraBlame original commit: 6f05409282886dfd20953c11cce41577aa106d1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.