Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to use trace hooks in conjunction with proxy objects #962

Closed
jdm opened this issue Sep 20, 2013 · 1 comment
Closed

Figure out how to use trace hooks in conjunction with proxy objects #962

jdm opened this issue Sep 20, 2013 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 20, 2013

Right now we don't trace HTMLDocument, so Document's trace hook never gets called and we don't trace the rest of the DOM tree. That's a problem.

@jdm
Copy link
Member Author

@jdm jdm commented Sep 20, 2013

#jsapi couldn't come up with any workarounds to do what I want right now, and bz's JSClass extension ideas for proxies sound more and more attractive. For the immediate problem of our DOM tree disappearing, we can either add back the explicit rooting for Document or explicitly call the Document trace hook from Window's hook.

@bors-servo bors-servo closed this in 5fc5542 Oct 1, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Add test for EventSource#url in url query encoding testsuite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.