Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete styles on Wikipedia pages #975

Closed
kmcallister opened this issue Sep 23, 2013 · 2 comments
Closed

Incomplete styles on Wikipedia pages #975

kmcallister opened this issue Sep 23, 2013 · 2 comments
Labels
A-content/css A-content/dom I-wrong

Comments

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Sep 23, 2013

Servo doesn't load the full set of style rules for e.g. http://en.wikipedia.org/wiki/Rust_%28programming_language%29. From the Firefox debug tools I see that the DOM contains a number of <style> elements not present in the static HTML; presumably they are created by scripts.

We currently fail to run some of the scripts on the page (#974) but even when that's fixed, I'm not sure dynamic creation of <style> elements will work.

For near-term demo purposes, perhaps we can find a no-JavaScript mode for Wikipedia.
@jdm
Copy link
Member

@jdm jdm commented Sep 23, 2013

#976 is related.
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@caitp
Only prefix url with resources/ if not in a worker context
f3b06e2 
Workers base url is already in the resources directory, so you resolve the url incorrectly if it is
prefixed with "resources/".

Good news, this gets the test passing in Gecko, Blink and Safari.

Closes servo#975
@nox
Copy link
Member

@nox nox commented Sep 29, 2017

This doesn't seem true to me anymore.
@nox nox closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css A-content/dom I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @nox @kmcallister
You can’t perform that action at this time.