Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Windows-based CI (AppVeyor et al) #9767

Closed
frewsxcv opened this issue Feb 26, 2016 · 8 comments
Closed

Incorporate Windows-based CI (AppVeyor et al) #9767

frewsxcv opened this issue Feb 26, 2016 · 8 comments

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Feb 26, 2016

Previous attempt #9406

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Feb 26, 2016

I've been working on this more here:
https://github.com/larsbergstrom/servo/tree/appveyor

@UK992
Copy link
Contributor

@UK992 UK992 commented Mar 2, 2016

I've been playing around Appveyor lately again and it work now.
Took 1 hour and 10 minutes to build, about half of this time only mozjs stuff.

https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.130
UK992@1cb6952

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Mar 2, 2016

@UK992 OMG, that's awesome! Fantastic work :-)

The nice thing about mozjs is that we should have CCACHE support, so we may be able to have that be a one-time (or once per-upgrade per-machine) deal.

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Mar 3, 2016

Hrm, it looks like heapsize is still failing with:

note: C:\Users\appveyor\AppData\Local\Temp\1\rustc.YtB1bF5ggNNd\libheapsize-da165bc9088f0d78.rlib(heapsize-da165bc9088f0d78.0.o): In function `heapsize::heap_size_of':
C:/projects/servo/.cargo\registry\src\github.com-88ac128001ac3a9a\heapsize-0.2.5\src/lib.rs:41: undefined reference to `je_malloc_usable_size'
collect2.exe: error: ld returned 1 exit status

error: aborting due to previous error
Build failed, waiting for other jobs to finish...

cc @Jayflux

@nox
Copy link
Member

@nox nox commented Mar 3, 2016

heapsize-0.2.5

You need to update that.

@UK992
Copy link
Contributor

@UK992 UK992 commented Mar 3, 2016

And also need this patch UK992@bf43c1c to solve alloc_jemalloc crate problem

@UK992
Copy link
Contributor

@UK992 UK992 commented Mar 3, 2016

And just for information, if building took more than 1 hour will hit build timeout, in that case, contact Appveyor support team for extend build timeout to 2 hours. I did this too.

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Mar 4, 2016

@UK992 I went ahead and contacted them, too, and they let me try the premium/2CPU machines. They took the build down to 52 minutes. I'm looking into possibly getting a premium contract for the Servo GH org :-)

bors-servo added a commit that referenced this issue Mar 4, 2016
Fix Windows build and add AppVeyor support

Proof of success: https://ci.appveyor.com/project/larsbergstrom/servo/build/1.0.15

Fixes #9767

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9863)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.