Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form + HTTP post doesn't work (or at least doesn't redirect) #9829

Closed
paulrouget opened this issue Mar 1, 2016 · 8 comments
Closed

form + HTTP post doesn't work (or at least doesn't redirect) #9829

paulrouget opened this issue Mar 1, 2016 · 8 comments
Assignees

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 1, 2016

Affects: github.com (can't log in).

Test case:

<form action="http://localhost:6060/b.html" method="post">
  <input value="click" type="submit">
</form>

Clicking on the button should load b.html. It doesn't.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 1, 2016

This prevents logging in Github.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 1, 2016

Using GET instead appears to work.
It also works if I use file:// instead of http://.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 1, 2016

This is because submit body for planned navigation hasn't been implemented yet. I think it's dependent on the encoding for multipart/form-data.

@psdh are you currently working on this? Or is it ok for someone else to work on it?

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 1, 2016

The relevant PR for encoding is #9198. I can fix the navigation problem after it lands.

@KiChjang KiChjang self-assigned this Mar 1, 2016
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 1, 2016

I can fix the navigation problem after it lands.

That would be great!

@paulrouget paulrouget mentioned this issue Mar 8, 2016
14 of 24 tasks complete
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 15, 2016

@KiChjang you implemented planned navigation recently. Is this done, or is there still work left?

Also, I guess this bug is why github's comment button doesn't work?

@jdm
Copy link
Member

@jdm jdm commented Mar 15, 2016

See the comment two before yours.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Apr 11, 2016

Suspected to be affecting Twitter login as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.