Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up./mach package #9918
./mach package #9918
Comments
|
I had a working prototype of this, which mainly involves creating a .app directory and moving stuff into the right places. If anyone else wants to work on this before I get back to it, I can post the Info.plist and steps I took. |
Can you post this? I'm trying to get the miniaturize/maximize buttons to work, but it requires the app to be properly packaged. |
|
I was roughly following this guide I found on how to build them: Note that we also need to copy resources into Servo.app as well. Here is my directory structure:
Here is the content of run-servo:
And here's my Info.plist:
Note that repeatedly running this would make it stop working until I changed CFBundleIdentifier (which is why it has a number after it). the launch daemon seems to cache a bunch of info and wasn't happy with something I was doing. I never did find a total solution for that and just kept working around it by changing the bundle id. |
|
Here's servo.icns as well. @paulrouget let me know if you need anything else. |
|
@edunham The |
|
Note: Glutin might overwrite |
…brubeck Fix Android APK building (packaging) Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy --faster` does not report any errors - [ ] These changes help with #10339. Either: - [x] There are tests for these changes (android-nightly builder) OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. I missed this syntax error during my review, and we don't check that packaging succeeds in regular build suite, but only as a Nightly build. @larsbergstrom should we run the packaging as part of the regular build? I think it is important that this continue to stay working, especially with #9918. In that case, the only difference with the nightly builder is whether or not to upload to S3. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11406) <!-- Reviewable:end -->
Start on Mach package Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [ ] `./mach build -d` does not report any errors - these changes don't touch anything that mach build touches> - [ ] `./mach test-tidy --faster` does not report any errors - Tidy errors on some dependencies that I think we'll need for real `package` but aren't using for android - [X] These changes address #9918 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't think Mach has tests yet? Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11210) <!-- Reviewable:end -->
Start on Mach package Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [ ] `./mach build -d` does not report any errors - these changes don't touch anything that mach build touches> - [ ] `./mach test-tidy --faster` does not report any errors - Tidy errors on some dependencies that I think we'll need for real `package` but aren't using for android - [X] These changes address #9918 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [x] These changes do not require tests because I don't think Mach has tests yet? Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11210) <!-- Reviewable:end -->
|
P3 -> P1. We will need to that if we want to release a developer preview of Servo + bhtml. |
|
I am working on the mac app bundle packager. |
|
Just a note. I have most of a |
|
Can this be closed now? |
We want to build a
.appor a.dmgfile on Mac. And zip files for Linux and Windows.They will include the Servo binary, the
resourcesfolder, and a copy of browserhtml.I think Jack is working on that.