Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable builds on the master branch for AppVeyor #9953
Comments
|
May i suggest to enable Rolling builds option, to shorten the build queue. Especially for unnecessary double builds on |
|
The last time we turned it on, it just seemed to be randomly canceling tons of builds. Though maybe that was actually servo/homu#23? @Manishearth @edunham Do you remember what was happening when we last tried Rolling Builds and had so little success? If it was indeed just the |
|
I don't recall the reason behind rolling builds failing. The easy way to make this work is to dynamically check if it's on the master branch and not a PR in the appveyor script and skip the build in that case. There's no configuration to do this. |
Appveyor: Cancel unnecessary builds on 'auto' branch This simple script will cancel build on ```auto``` branch if same commit already exist in ```master```. As a part of solution mentioned in #9953 Tested: Commit on master: [Appveyor/1.0.300](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.300) Same commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.301) Different commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.302) r? @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10340) <!-- Reviewable:end -->
|
@larsbergstrom Now that Windows builds running on dedicated buildbot machine, should be |
|
@UK992 Good call! I've excluded them from the AppVeyor settings :-) But yes, we could remove them from the appveyor.yml. |
Remove auto and try branch from appveyor.yml Closes #9953 r? @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11066) <!-- Reviewable:end -->
…ranch (from UK992:win32); r=larsbergstrom This simple script will cancel build on ```auto``` branch if same commit already exist in ```master```. As a part of solution mentioned in servo/servo#9953 Tested: Commit on master: [Appveyor/1.0.300](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.300) Same commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.301) Different commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.302) r? larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 5333f564cd2f97ad78d2edc53f3791461b4b9244 UltraBlame original commit: 729ff86b053ff04d197067887c26fdcbe76e1297
…ranch (from UK992:win32); r=larsbergstrom This simple script will cancel build on ```auto``` branch if same commit already exist in ```master```. As a part of solution mentioned in servo/servo#9953 Tested: Commit on master: [Appveyor/1.0.300](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.300) Same commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.301) Different commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.302) r? larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 5333f564cd2f97ad78d2edc53f3791461b4b9244 UltraBlame original commit: 729ff86b053ff04d197067887c26fdcbe76e1297
…ranch (from UK992:win32); r=larsbergstrom This simple script will cancel build on ```auto``` branch if same commit already exist in ```master```. As a part of solution mentioned in servo/servo#9953 Tested: Commit on master: [Appveyor/1.0.300](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.300) Same commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.301) Different commit on auto: [Appveyor/1.0.302](https://ci.appveyor.com/project/UK992/servo-hga0y/build/1.0.302) r? larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 5333f564cd2f97ad78d2edc53f3791461b4b9244 UltraBlame original commit: 729ff86b053ff04d197067887c26fdcbe76e1297
Currently, AppVeyor builds the master branch every time that something is merged into it (see: https://ci.appveyor.com/project/servo/servo/history). However, that's not entirely useful, since it has already built exactly that commit on the
autobranch in order to land it!We'd like to either disable or no-op the builds on master... but hopefully without breaking AppVeyor builds on PR branches.