Avoid calling layout_font_group_for_style when there's a more direct way to get a fragment's font metrics #9954

jdm · 2016-03-10T19:12:11Z

The PR in #9196 had a 31% layout time improvement on https://drafts.csswg.org/css-backgrounds-3/, but it also had a test failure:

  ▶ FAIL [expected PASS] /_mozilla/css/line_breaking_whitespace_collapse_a.html
  └   → /_mozilla/css/line_breaking_whitespace_collapse_a.html 117395f5c755abaebbcdef86ebfef696f64b8137
/_mozilla/css/line_breaking_whitespace_collapse_ref.html c3bc177ff55f7250853bfd581426840809dcd247
Testing 117395f5c755abaebbcdef86ebfef696f64b8137 == c3bc177ff55f7250853bfd581426840809dcd247

jdm added A-layout/uncategorized I-perf-slow labels Mar 10, 2016

jdm mentioned this issue Mar 10, 2016

Don't call `layout_font_group_for_style()` to fetch the font metrics for a fragment if there's a more direct way to get to them. #9196

Closed

servo / servo

Avoid calling layout_font_group_for_style when there's a more direct way to get a fragment's font metrics #9954

Avoid calling layout_font_group_for_style when there's a more direct way to get a fragment's font metrics #9954

jdm commented Mar 10, 2016

servo / servo

Join GitHub today

Avoid calling layout_font_group_for_style when there's a more direct way to get a fragment's font metrics #9954

Avoid calling layout_font_group_for_style when there's a more direct way to get a fragment's font metrics #9954

Comments

jdm commented Mar 10, 2016