Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the whitespace flag in each glyph instead of going to the string for whitespace stripping #9955

Open
jdm opened this issue Mar 10, 2016 · 0 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 10, 2016

The PR in #8994 was designed to fix "str::slice_chars was O(n) and #2 in the profile." but it had test failures:

  ▶ FAIL [expected PASS] /css21_dev/html4/block-non-replaced-width-007.htm
  └   → /css21_dev/html4/block-non-replaced-width-007.htm eb195905e02d7943de70d2b8ac617e074179e996
/css21_dev/html4/reference/block-non-replaced-width-007-ref.htm 47ad8313feacfb8add7c5d1c014c7975027bf5b7
Testing eb195905e02d7943de70d2b8ac617e074179e996 == 47ad8313feacfb8add7c5d1c014c7975027bf5b7

  ▶ PASS [expected FAIL] /css21_dev/html4/floats-wrap-bfc-002-right-table.htm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.