Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframes not clipped by border radius #9983

Closed
paulrouget opened this issue Mar 14, 2016 · 3 comments
Closed

iframes not clipped by border radius #9983

paulrouget opened this issue Mar 14, 2016 · 3 comments
Assignees
Labels

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 14, 2016

Affects browserhtml

border-radius on a iframe and its parents doesn't clip the content of the iframe.

Happens both with and without webrender.

<style>
  div {
    display: inline-block;
    border-radius: 0 0 50px 50px;
    border: 5px solid red;
    overflow: hidden;
  }
  iframe {
    border: 5px solid green;
    display: block;
    height: 100px;
    width: 100px;
    border-radius: 50px 50px 0 0;
  }
</style>
<div>
  <iframe src="data:text/html,<style>body{background:orange}</style>"></iframe>
</div>

screen shot 2016-03-14 at 06 17 13

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Mar 16, 2016

We actually don't support clipping iframes at all. The appropriate clip region isn't being communicated to WebRender, and WebRender isn't using it. Working on a fix.

pcwalton added a commit to pcwalton/webrender_traits that referenced this issue Mar 31, 2016
pcwalton added a commit to pcwalton/webrender that referenced this issue Mar 31, 2016
bors-servo added a commit to servo/webrender_traits that referenced this issue Apr 8, 2016
Communicate iframe clipping regions to WebRender.

Partially addresses servo/servo#9983.

r? @glennw
dzbarsky added a commit to dzbarsky/webrender_traits that referenced this issue Apr 17, 2016
pcwalton added a commit to pcwalton/webrender that referenced this issue May 10, 2016
bors-servo added a commit to servo/webrender that referenced this issue May 10, 2016
Clip iframes to clipping regions that consist of single rectangles.

This is a prerequisite to solving servo/servo#9983.

Requires servo/webrender_traits#28.

r? @glennw
@nox nox added the C-assigned label Jun 20, 2016
@mrobinson mrobinson self-assigned this Apr 7, 2017
@mrobinson
Copy link
Member

@mrobinson mrobinson commented Apr 7, 2017

Assigning myself here as well, because I've been working on this as well and should be able to have a fix rather quickly.

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Jul 20, 2017

This should be fixed by #17771.

@mrobinson mrobinson closed this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.