Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement stub for NavigatorPlugins #9991
Closed
Labels
Comments
|
Claiming this temporarily for potential RGSoC applicants. Please contact me before starting to work on this. |
|
This is available for anyone to work on. |
|
I would like to work on this one. |
|
Go ahead! |
bors-servo
added a commit
that referenced
this issue
Apr 11, 2016
Implement stub for NavigatorPlugins This PR implements stub for NavigatorPlugins as outlined in #9991. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10485) <!-- Reviewable:end -->
|
Implemented in #10485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Servo has no support for traditional browser plugins, so the actual implementation should be fairly straightforward (ie. returning None/0/false, etc.).
Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2 (and add
Navigator implements NavigatorPlugins;)Code:
components/script/dom/webidls/:Navigator.webidl,PluginArray.webidl,Plugin.webidl,MimeTypeArray.webidl,MimeType.webidlcomponents/script/dom/:navigator.rs,pluginarray.rs,plugin.rs,mimetypearray.rs,mimetype.rsTests:
./mach test-wpt tests/wpt/mozilla/tests/mozilla/interfaces.html(modify this test to pass)./mach test-wpt tests/wpt/web-platform-tests/html/dom/interfaces.html(update theinterfaces.html.inifile to accommodate the new passing tests)See the documentation for steps to follow when adding new WebIDL interfaces.
This work is important because when
navigator.pluginsis missing, clicking links on Twitter is broken (see #9870).