Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stub for NavigatorPlugins #9991

Closed
jdm opened this issue Mar 14, 2016 · 5 comments
Closed

Implement stub for NavigatorPlugins #9991

jdm opened this issue Mar 14, 2016 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 14, 2016

Servo has no support for traditional browser plugins, so the actual implementation should be fairly straightforward (ie. returning None/0/false, etc.).

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2 (and add Navigator implements NavigatorPlugins;)
Code:

  • in components/script/dom/webidls/:
    • Navigator.webidl, PluginArray.webidl, Plugin.webidl, MimeTypeArray.webidl, MimeType.webidl
  • in components/script/dom/:
    • navigator.rs, pluginarray.rs, plugin.rs, mimetypearray.rs, mimetype.rs
      Tests:
  • ./mach test-wpt tests/wpt/mozilla/tests/mozilla/interfaces.html (modify this test to pass)
  • ./mach test-wpt tests/wpt/web-platform-tests/html/dom/interfaces.html (update the interfaces.html.ini file to accommodate the new passing tests)

See the documentation for steps to follow when adding new WebIDL interfaces.

This work is important because when navigator.plugins is missing, clicking links on Twitter is broken (see #9870).

@jdm
Copy link
Member Author

@jdm jdm commented Mar 14, 2016

Claiming this temporarily for potential RGSoC applicants. Please contact me before starting to work on this.

@jdm jdm added E-easy and removed C-assigned labels Apr 8, 2016
@jdm
Copy link
Member Author

@jdm jdm commented Apr 8, 2016

This is available for anyone to work on.

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 8, 2016

I would like to work on this one.

@jdm
Copy link
Member Author

@jdm jdm commented Apr 8, 2016

Go ahead!

@jdm jdm added the C-assigned label Apr 8, 2016
bors-servo added a commit that referenced this issue Apr 11, 2016
Implement stub for NavigatorPlugins

This PR implements stub for NavigatorPlugins as outlined in #9991.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10485)
<!-- Reviewable:end -->
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 11, 2016

Implemented in #10485

@KiChjang KiChjang closed this Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.