Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement NavigatorLanguage #9992
Comments
|
I'll take that, will help me get familiar with dom parts. |
|
Great! |
|
I am getting an error from the |
|
Start with just |
implements NavigatorLanguage For #9992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10009) <!-- Reviewable:end -->
implements NavigatorLanguage Fixes #9992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10009) <!-- Reviewable:end -->
implements NavigatorLanguage Fixes #9992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10009) <!-- Reviewable:end -->
Spec: https://html.spec.whatwg.org/multipage/webappapis.html#navigatorlanguage (and add
Navigator implements NavigatorLanguage;)Code:
components/script/dom/webidls/Navigator.webidl,components/script/dom/navigator.rsTests:
./mach test-wpt tests/wpt/html/dom/interfaces.html./mach test-wpt tests/wpt/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigatorlanguage.htmlThe lack of this feature is makes clicking links on Twitter break (see #9870). Let's just hardcode this as
en-USright now.