Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHighlight text selection #9993
Closed
Highlight text selection #9993
Assignees
Comments
|
The right thing is to split fragments but not text runs, I believe. That's because anything you can style as one unit in CSS needs to be a fragment, but anything ligatures work across needs to be one text run. |
|
I've started working on the layout parts of this (fragment splitting and display list generation). |
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Mar 24, 2016
Fixes servo#9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Mar 24, 2016
Fixes servo#9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Mar 24, 2016
Fixes servo#9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Mar 24, 2016
Fixes servo#9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Mar 25, 2016
Fixes servo#9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground.
bors-servo
added a commit
that referenced
this issue
Mar 25, 2016
Highlight selected text in input fields Fixes #9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10176) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Mar 26, 2016
Highlight selected text in input fields Fixes #9993. This does not yet allow stylesheets to set the selection colors; instead it uses a hard-coded orange background and white foreground. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10176) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We already support keyboard text selection (with Shift + arrows) in
<input>, but it’s invisible. This issue is about changing the text color and background color of selected text, like other browsers do. Colors can be hard-coded at first, #8077 is about adding a::selectionpseudo-element to change them with CSS.I don’t know if we’re better off splitting text fragments in layout at selection boundaries, or only splitting display items. @pcwalton, do you have an opinion on this?
CC @paulrouget