Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch handles exception with errormessage on topdir with Unicode characters. #10003

Merged
merged 1 commit into from Mar 16, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Handle exception with errormessage on topdir with Unicode characters.

  • Loading branch information
qaxi committed Mar 15, 2016
commit c0bc90d12232f5bee2ce8978c5dd44ee830c0c47
@@ -149,6 +149,15 @@ def _activate_virtualenv(topdir):
def bootstrap(topdir):
topdir = os.path.abspath(topdir)

# We don't support paths with Unicode characters for now
# https://github.com/servo/servo/issues/10002
try:
topdir.decode('ascii')
except UnicodeDecodeError:
print('Cannot run mach in a path with Unicode characters.')
print('Current path:', topdir)
sys.exit(1)

# We don't support paths with spaces for now
# https://github.com/servo/servo/issues/9442
if ' ' in topdir:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.