Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overflow references on AssignBSizesAndStoreOverflow code #10061

Merged
merged 1 commit into from Mar 17, 2016
Merged

Remove overflow references on AssignBSizesAndStoreOverflow code #10061

merged 1 commit into from Mar 17, 2016

Conversation

@DavidBM
Copy link
Contributor

DavidBM commented Mar 17, 2016

This change is Reviewable
@DavidBM
Removed overflow references on AssignBSizesAndStoreOverflow code
Loading status checks…
57df260
@highfive
Copy link

highfive commented Mar 17, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.
@highfive
Copy link

highfive commented Mar 17, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Mar 17, 2016

r? @mbrubeck

(I'm not sure why this change is being made 😄 )
@highfive highfive assigned mbrubeck and unassigned Ms2ger Mar 17, 2016
@tschneidereit
Copy link
Contributor

tschneidereit commented Mar 17, 2016

@Manishearth, @mbrubeck suggested this as a good first change for @DavidBM, whom I'm teaching the basics of contributing to Servo at a community event here in Berlin.
@Manishearth
Copy link
Member

Manishearth commented Mar 17, 2016

@bors-servo r+

Ah, okay.

Thanks for the change!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

📌 Commit 57df260 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

⌛ Testing commit 57df260 with merge ce2da28...
bors-servo added a commit that referenced this pull request Mar 17, 2016
@bors-servo
Auto merge of #10061 - DavidBM:clean_code_removing_overflow_in_assign…
Loading status checks…
ce2da28 
…_bsizes, r=Manishearth

Remove overflow references on AssignBSizesAndStoreOverflow code

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10061)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Mar 17, 2016

@DavidBM Don't worry, nothing's wrong with your code, we just have intermittent issues that occassionally pop up when we run our WPT tests.

Also, welcome to Servo!

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Mar 17, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit 57df260 into servo:master Mar 17, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@DavidBM
Copy link
Contributor Author

DavidBM commented Mar 18, 2016

Thanks you :)
There is a lot of automation here!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@DavidBM @highfive @Manishearth @tschneidereit @bors-servo @KiChjang @mbrubeck @Ms2ger
You can’t perform that action at this time.