Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable cross origin check for mozbrowser-enabled top level pipelines #10068
Conversation
|
Remove |
41aa98e
to
fd6878c
Done. |
|
Anything in particular that might prevent this to land? |
|
-S-awaiting-review +S-needs-code-changes Reviewed 3 of 4 files at r1. components/script/dom/xmlhttprequest.rs, line 878 [r2] (raw file): tests/wpt/mozilla/tests/mozilla/mozbrowser/crossorigin_xhr.html, line 14 [r2] (raw file): tests/wpt/mozilla/tests/mozilla/mozbrowser/crossorigin_xhr.html, line 19 [r2] (raw file): Comments from the review on Reviewable.io |
fd6878c
to
0b65411
|
Addressed comments. For workers, I don't think there's an easy way to know if it's part of the top level window. We don't need it now though. |
|
-S-awaiting-review +S-needs-code-changes Reviewed 3 of 3 files at r3. components/script/dom/xmlhttprequest.rs, line 878 [r1] (raw file): if let GlobalRoot::Window(win) = self.global() {
let is_root_pipeline = win.parent_info.is_none();
...
}Comments from the review on Reviewable.io |
0b65411
to
dd08e90
|
@bors-servo: r+ Reviewed 2 of 2 files at r4. Comments from the review on Reviewable.io |
|
|
Disable cross origin check for mozbrowser-enabled top level pipelines Closes #9582 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10068) <!-- Reviewable:end -->
|
|
paulrouget commentedMar 18, 2016
Closes #9582
This change is