Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the final step for event dispatcher `invoke` #10069

Closed
wants to merge 1 commit into from

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Mar 18, 2016

r? @nox


This change is Reviewable

@highfive
Copy link

highfive commented Mar 18, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@wafflespeanut wafflespeanut changed the title Added the final step for invoke in event-dispatcher Added the final step for event dispatcher `invoke` Mar 18, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 18, 2016

I'm not sure we should implement this in isolation from the rest of the webkit-prefixed animation stuff.

In any case, I want a boatload of tests.

@nox nox added the C-needs-test label Mar 20, 2016
@nox
Copy link
Member

nox commented Mar 20, 2016

@nox
Copy link
Member

nox commented Mar 20, 2016

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


components/script/dom/eventdispatcher.rs, line 195 [r1] (raw file):
Nit: original_event_type.


components/script/dom/eventdispatcher.rs, line 195 [r1] (raw file):
Nit: "Step 5.1."


components/script/dom/eventdispatcher.rs, line 196 [r1] (raw file):
Nit: "Step 5.2."


components/script/dom/eventdispatcher.rs, line 204 [r1] (raw file):
Nit: "Step 5.3."


components/script/dom/eventdispatcher.rs, line 205 [r1] (raw file):
Nit: "Step 5.4."


Comments from the review on Reviewable.io

@nox
Copy link
Member

nox commented Apr 15, 2016

@wafflespeanut wafflespeanut force-pushed the wafflespeanut:event_dispatch branch from 88ca8dc to 7abe338 Apr 15, 2016
@wafflespeanut wafflespeanut force-pushed the wafflespeanut:event_dispatch branch from 7abe338 to 57abae9 Apr 15, 2016
@nox
Copy link
Member

nox commented Apr 18, 2016

Still needs tests.

-S-awaiting-review +S-needs-code-changes


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


components/script/dom/eventdispatcher.rs, line 212 [r2] (raw file):
Still a typo in original_event_type, that doesn't compile.


Comments from Reviewable

@wafflespeanut wafflespeanut force-pushed the wafflespeanut:event_dispatch branch from 57abae9 to d94bf88 Apr 18, 2016
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Apr 18, 2016

Oh, that's just plain stupid. I'm sorry :)

@wafflespeanut
Copy link
Member Author

wafflespeanut commented Apr 23, 2016

@nox I'm sorry. I don't think I'll be able to finish this off anytime soon - I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.