Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded the final step for event dispatcher `invoke` #10069
Conversation
highfive
commented
Mar 18, 2016
|
I'm not sure we should implement this in isolation from the rest of the webkit-prefixed animation stuff. In any case, I want a boatload of tests. |
|
See existing tests in /tests/wpt/web-platform-tests/dom/events. |
|
Reviewed 2 of 2 files at r1. components/script/dom/eventdispatcher.rs, line 195 [r1] (raw file): components/script/dom/eventdispatcher.rs, line 195 [r1] (raw file): components/script/dom/eventdispatcher.rs, line 196 [r1] (raw file): components/script/dom/eventdispatcher.rs, line 204 [r1] (raw file): components/script/dom/eventdispatcher.rs, line 205 [r1] (raw file): Comments from the review on Reviewable.io |
|
@wafflespeanut Ping? |
88ca8dc
to
7abe338
7abe338
to
57abae9
|
Still needs tests. -S-awaiting-review +S-needs-code-changes Reviewed 1 of 1 files at r2. components/script/dom/eventdispatcher.rs, line 212 [r2] (raw file): Comments from Reviewable |
57abae9
to
d94bf88
|
Oh, that's just plain stupid. I'm sorry :) |
|
@nox I'm sorry. I don't think I'll be able to finish this off anytime soon - I'll close this. |
wafflespeanut commentedMar 18, 2016
r? @nox
This change is