Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny unsafe code in more crates. #10075

Merged
merged 2 commits into from Mar 20, 2016
Merged

Deny unsafe code in more crates. #10075

merged 2 commits into from Mar 20, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 18, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Mar 18, 2016

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Mar 18, 2016

warning Warning warning

  • These commits modify gfx and style code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Mar 18, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2016

📌 Commit 08083f1 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2016

Testing commit 08083f1 with merge 5d8037a...

bors-servo added a commit that referenced this pull request Mar 18, 2016
Deny unsafe code in more crates.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10075)
<!-- Reviewable:end -->
@jdm jdm assigned jdm and unassigned Ms2ger Mar 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2016

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Mar 18, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2016

Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2016

💥 Test timed out

@KiChjang
Copy link
Member

KiChjang commented Mar 19, 2016

@bors-servo retry

  • Timed out tests?!?!
@frewsxcv frewsxcv closed this Mar 20, 2016
@frewsxcv frewsxcv reopened this Mar 20, 2016
@KiChjang
Copy link
Member

KiChjang commented Mar 20, 2016

@bors-servo retry clean

@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2016

Testing commit 08083f1 with merge 8c92e3f...

bors-servo added a commit that referenced this pull request Mar 20, 2016
Deny unsafe code in more crates.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10075)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2016

@bors-servo bors-servo merged commit 08083f1 into servo:master Mar 20, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:deny-unsafe branch Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.