Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReport memory usage from LayoutThreadData Stylist [#7038] #10088
Conversation
highfive
commented
Mar 19, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 19, 2016
|
|
|
You should be able to update heapsize using: Hopefully you don't run into any version number conflicts. |
pkondzior
force-pushed the
pkondzior:7038-report-memory-usage-in-layout-thread-data-stylist
branch
from
de4adaf
to
db2e10a
|
@ecoal95 fixed, thanks! |
|
This looks good to me :) @bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 21, 2016
…hread-data-stylist, r=ecoal95 Report memory usage from LayoutThreadData Stylist [#7038] @jdm PTAL I'm not sure what is the approach of updating cargo components here, I've made a pull request servo/heapsize#54 but it has to be landed first before merge and version bump. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10088) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Mar 22, 2016
…hread-data-stylist, r=ecoal95 Report memory usage from LayoutThreadData Stylist [#7038] @jdm PTAL I'm not sure what is the approach of updating cargo components here, I've made a pull request servo/heapsize#54 but it has to be landed first before merge and version bump. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10088) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pkondzior commentedMar 19, 2016
@jdm PTAL I'm not sure what is the approach of updating cargo components here, I've made a pull request servo/heapsize#54 but it has to be landed first before merge and version bump.
This change is