Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes for compute_damage #10109
Merged
Fixes for compute_damage #10109
Conversation
|
r? @pcwalton |
|
@bors-servo: r+ Looks good! |
|
|
|
|
mbrubeck
force-pushed the
mbrubeck:compute_damage_short_circuit
branch
from
b899ec2
to
f7d490a
|
@bors-servo r=pcwalton rebased |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 22, 2016
Fixes for compute_damage A few changes: * Make `compute_damage` short-circuit more, by skipping comparisons if they will only set flags that are already set. * Update some obsolete comments. * Add a bunch of missing properties to `compute_damage`. * Set `RECONSTRUCT_FLOW` when `text-decoration` changes, because it can affect text fragment splitting/merging. I believe this is all of the computed properties except for the animation properties. (I wasn't sure what to do with those.) After this lands I'd like to work on moving this information into `properties.mako.rs` so that this function can be auto-generated, and so that newly-added properties can default to setting all flags instead of none. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10109) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMar 21, 2016
A few changes:
compute_damageshort-circuit more, by skipping comparisons if they will only set flags that are already set.compute_damage.RECONSTRUCT_FLOWwhentext-decorationchanges, because it can affect text fragment splitting/merging.I believe this is all of the computed properties except for the animation properties. (I wasn't sure what to do with those.) After this lands I'd like to work on moving this information into
properties.mako.rsso that this function can be auto-generated, and so that newly-added properties can default to setting all flags instead of none.This change is