Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitflags 0.5 #10140

Closed
wants to merge 0 commits into from
Closed

Use bitflags 0.5 #10140

wants to merge 0 commits into from

Conversation

@saurvs
Copy link
Contributor

saurvs commented Mar 23, 2016

Also remove bitflags from the list of exceptions in tidy.py

Part of #10077

This change is Reviewable
@highfive
Copy link

highfive commented Mar 23, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Mar 23, 2016

warning Warning warning

  • These commits modify gfx, layout, style, and script code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member

KiChjang commented Mar 23, 2016

Is this update done through ./mach update-cargo -p bitflags?
@KiChjang
Copy link
Member

KiChjang commented Mar 30, 2016

@saurvs Ping?
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

☔ The latest upstream changes (presumably #10285) made this pull request unmergeable. Please resolve the merge conflicts.
@saurvs saurvs closed this Apr 2, 2016
@saurvs
Copy link
Contributor Author

saurvs commented Apr 2, 2016

@KiChjang Sorry about the delay to reply!

No I had not used mach. And I think I'll have to upgrade every crate Servo depends on to bitflags 0.5 before doing the same for Servo. It might take a while!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-awaiting-answer S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@saurvs @highfive @KiChjang @bors-servo
You can’t perform that action at this time.