Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Firefox to be able to connect to devtools again #10158

Merged
merged 3 commits into from Mar 24, 2016
Merged

Conversation

@nox
Copy link
Member

nox commented Mar 24, 2016

This doesn't fix the performance tab, but at least lets Firefox initialise the devtools window.


This change is Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 24, 2016

./components/devtools/lib.rs:78: mod declaration is not in alphabetical order
    expected: timeline
    found: thread

r+ with that fixed.

@Ms2ger Ms2ger assigned Ms2ger and unassigned metajack Mar 24, 2016
nox added 2 commits Mar 23, 2016
These should represent JavaScript contexts, but not defining them at all
prevent any remote debugging session to be started from Firefox. They shouldn't
be conflated with tab actors.
@nox nox force-pushed the nox:devtools branch from c8c3105 to 04e085a Mar 24, 2016
@nox
Copy link
Member Author

nox commented Mar 24, 2016

10:30 <•Ms2ger> r+ it? I don't have the tab anymore

@bors-servo r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

📌 Commit 04e085a has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

Testing commit 04e085a with merge e9d7510...

bors-servo added a commit that referenced this pull request Mar 24, 2016
Allow Firefox to be able to connect to devtools again

This doesn't fix the performance tab, but at least lets Firefox initialise the devtools window.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10158)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

💔 Test failed - linux-rel

@nox
Copy link
Member Author

nox commented Mar 24, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

Testing commit 04e085a with merge 5faab27...

bors-servo added a commit that referenced this pull request Mar 24, 2016
Allow Firefox to be able to connect to devtools again

This doesn't fix the performance tab, but at least lets Firefox initialise the devtools window.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10158)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

nox commented Mar 24, 2016

Y U NO REUSE

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

@bors-servo bors-servo merged commit 04e085a into servo:master Mar 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.