Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix forced repaint on image load #10197
Merged
Conversation
highfive
commented
Mar 25, 2016
|
|
|
I can't easily test this because we disable async image loading when running reftests. |
|
Huh, I was working on my own implementation of this. I was under the impression that background images have no mechanism of triggering reflows at all when loaded (as opposed to |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2016
Fix forced repaint on image load After #10021, `LayoutThread::repaint` no longer forced a repaint because of the `restyle_damage` check. This patch adds the correct restyle damage and fixes #10163. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10197) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMar 25, 2016
After #10021,
LayoutThread::repaintno longer forced a repaint because of therestyle_damagecheck. This patch adds the correct restyle damage and fixes #10163.r? @pcwalton
This change is