Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented WebGLRenderingContext.Flush() #10218

Closed
wants to merge 1 commit into from
Closed

Implemented WebGLRenderingContext.Flush() #10218

wants to merge 1 commit into from

Conversation

@cbrewster
Copy link
Member

cbrewster commented Mar 27, 2016

Implements #10213
Depends on servo/webrender_traits#23

r? @emilio

This change is Reviewable
@cbrewster
Added flush function for webgl
Loading status checks…
e184f86
@highfive
Copy link

highfive commented Mar 27, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl
  • @emilio: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Mar 27, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Mar 27, 2016

I'd try to use the same pr for both this and #10215, since you'll have to rebase one on top of the other otherwise, but it looks good! :)
@cbrewster
Copy link
Member Author

cbrewster commented Mar 27, 2016

@emilio I'll go ahead and merge them then
@cbrewster cbrewster closed this Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-awaiting-review S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cbrewster @highfive @emilio
You can’t perform that action at this time.