Replace any uses of .send().unwrap() by .send().unwrap_or_else(). #10242

asajeffrey · 2016-03-28T18:29:53Z

This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.

This change is

metajack · 2016-03-28T19:27:32Z

@bors-servo r+

This looks like it will give us much more information on these kinds of errors. That should be a definite improvement.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

bors-servo · 2016-03-28T19:27:33Z

📌 Commit 75420b4 has been approved by metajack

asajeffrey · 2016-03-28T19:33:49Z

@metajack thanks!

asajeffrey · 2016-03-28T22:36:28Z

@bors-servo: try r=metajack

bors-servo · 2016-03-28T22:36:29Z

📌 Commit c2f4208 has been approved by metajack

bors-servo · 2016-03-28T22:36:31Z

⌛ Trying commit c2f4208 with merge 401a6bb...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-28T22:56:07Z

💔 Test failed - mac-rel-css

asajeffrey · 2016-03-28T23:17:08Z

@bors-servo: retry

bors-servo · 2016-03-28T23:17:10Z

⌛ Trying commit c2f4208 with merge bcdd4b5...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-29T01:00:19Z

💔 Test failed - status-appveyor

asajeffrey · 2016-03-29T01:15:56Z

Hmm, that's two random git failures in a row... @bors-servo: retry

bors-servo · 2016-03-29T01:15:58Z

⌛ Trying commit c2f4208 with merge c0184ba...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-29T03:27:13Z

💔 Test failed - status-appveyor

asajeffrey · 2016-03-29T15:32:57Z

Rebased and git push --force to see if this fixes the problem with appveyor git checkout (e.g. https://ci.appveyor.com/project/servo/servo/build/1.0.1416).

asajeffrey · 2016-03-29T18:08:35Z

@bors-servo: try r=metajack

bors-servo · 2016-03-29T18:08:36Z

📌 Commit 620ba84 has been approved by metajack

bors-servo · 2016-03-29T18:08:38Z

⌛ Trying commit 620ba84 with merge 3e40ae7...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-29T19:46:50Z

💔 Test failed - status-appveyor

asajeffrey · 2016-03-30T01:26:08Z

@bors-servo: retry

#10251

bors-servo · 2016-03-30T01:26:10Z

⌛ Trying commit 620ba84 with merge 2b7ecc0...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-30T12:10:32Z

💥 Test timed out

asajeffrey · 2016-03-30T12:33:16Z

@bors-servo retry

"Test timed out"

bors-servo · 2016-03-30T12:33:18Z

⌛ Trying commit 620ba84 with merge e1f1378...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…<try> Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-30T13:36:36Z

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

bors-servo · 2016-03-30T13:36:39Z

⌛ Testing commit 620ba84 with merge 821afa0...


        Auto merge of #10242 - asajeffrey:remove-constellation-send-panic, r=…

…metajack Replace any uses of .send().unwrap() by .send().unwrap_or_else(). This is part of the effort to harden the constellation (#10124), in this case against panics caused by channel send.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10242)

bors-servo · 2016-03-30T14:28:29Z

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

highfive assigned metajack Mar 28, 2016

highfive added the S-awaiting-review label Mar 28, 2016

asajeffrey mentioned this pull request Mar 28, 2016

Constellation hardening metabug #10124

Closed

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 28, 2016

asajeffrey force-pushed the asajeffrey:remove-constellation-send-panic branch from 75420b4 to 30c1a98 Mar 28, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Mar 28, 2016

asajeffrey force-pushed the asajeffrey:remove-constellation-send-panic branch from 30c1a98 to c2f4208 Mar 28, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 28, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 28, 2016

highfive added the S-tests-failed label Mar 29, 2016

asajeffrey force-pushed the asajeffrey:remove-constellation-send-panic branch from c2f4208 to 620ba84 Mar 29, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Mar 29, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 29, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 29, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Mar 30, 2016

bors-servo merged commit 620ba84 into servo:master Mar 30, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

This was referenced Mar 30, 2016

script: Make iframes know their pipeline IDs at all times, even after navigation. #10159

Merged

Removed panicking when frame or pipeline lookup fails. #10082

Merged

webgl: Add attribute validations and other nits #10224

Merged

servo / servo

Replace any uses of .send().unwrap() by .send().unwrap_or_else(). #10242

Replace any uses of .send().unwrap() by .send().unwrap_or_else(). #10242

asajeffrey commented Mar 28, 2016

metajack commented Mar 28, 2016

bors-servo commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

asajeffrey commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

servo / servo

Join GitHub today

Replace any uses of .send().unwrap() by .send().unwrap_or_else(). #10242

Replace any uses of .send().unwrap() by .send().unwrap_or_else(). #10242

Conversation

asajeffrey commented Mar 28, 2016

metajack commented Mar 28, 2016

bors-servo commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 28, 2016

asajeffrey commented Mar 28, 2016

bors-servo commented Mar 28, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

asajeffrey commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

bors-servo commented Mar 29, 2016

asajeffrey commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

asajeffrey commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016

bors-servo commented Mar 30, 2016