Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipc-channel to fix leaks and spurious ENOBUFS. #10253

Merged
merged 1 commit into from Mar 29, 2016

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Mar 29, 2016

Supersedes #10241 (fixes #10029).
Also fixes #9555 (hopefully for good).


This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 29, 2016
@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit a2eecaa has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 29, 2016
@Manishearth
Copy link
Member

@bors-servo p=1

@bors-servo
Copy link
Contributor

⌛ Testing commit a2eecaa with merge 32f0e5d...

bors-servo pushed a commit that referenced this pull request Mar 29, 2016
Update ipc-channel to fix leaks and spurious ENOBUFS.

Supersedes #10241 (fixes #10029).
Also fixes #9555 (hopefully for good).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-appveyor

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 29, 2016
@jdm
Copy link
Member

jdm commented Mar 29, 2016

@Manishearth
Copy link
Member

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit a2eecaa with merge ddc57fe...

bors-servo pushed a commit that referenced this pull request Mar 29, 2016
Update ipc-channel to fix leaks and spurious ENOBUFS.

Supersedes #10241 (fixes #10029).
Also fixes #9555 (hopefully for good).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10253)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 29, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

@bors-servo bors-servo merged commit a2eecaa into servo:master Mar 29, 2016
@eddyb eddyb deleted the ipc-update branch March 29, 2016 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
7 participants