Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reference-counting Runtime for workers. #10268

Merged
merged 1 commit into from Mar 30, 2016
Merged

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 29, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Mar 29, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/workerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs
@highfive
Copy link

highfive commented Mar 29, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Mar 29, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2016

📌 Commit aeab05c has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2016

Testing commit aeab05c with merge ca9f192...

bors-servo added a commit that referenced this pull request Mar 29, 2016
Stop reference-counting Runtime for workers.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10268)
<!-- Reviewable:end -->
#[ignore_heap_size_of = "Defined in std"]
runtime: Rc<Runtime>,
#[ignore_heap_size_of = "Defined in js"]
runtime: Runtime,
next_worker_id: Cell<WorkerId>,
#[ignore_heap_size_of = "Defined in std"]

This comment has been minimized.

@emilio

emilio Mar 29, 2016

Member

This comment might deserve to be updated?

@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2016

💔 Test failed - status-appveyor

@jdm
Copy link
Member

jdm commented Mar 30, 2016

bors-servo added a commit that referenced this pull request Mar 30, 2016
Stop reference-counting Runtime for workers.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10268)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit aeab05c with merge e5e559d...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

@bors-servo bors-servo merged commit aeab05c into servo:master Mar 30, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:rc-runtime branch Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.