Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde in devtools #10285

Merged
merged 1 commit into from Mar 31, 2016
Merged

Use serde in devtools #10285

merged 1 commit into from Mar 31, 2016

Conversation

@nox
Copy link
Member

nox commented Mar 30, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Mar 30, 2016

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Mar 30, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox nox force-pushed the nox:devtools-serde branch from 5b2f2f5 to 6657355 Mar 30, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 30, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit 6657355 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 6657355 with merge 3ad29d2...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Use serde in devtools

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10285)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

💔 Test failed - linux-dev

@edunham
Copy link
Contributor

edunham commented Mar 30, 2016

@bors-servo retry

Infra downtime for servo/saltfs#281 interrupted the build

@edunham
Copy link
Contributor

edunham commented Mar 30, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 6657355 with merge 723acd7...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Use serde in devtools

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10285)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

💔 Test failed - linux-dev

@jdm
Copy link
Member

jdm commented Mar 30, 2016

test-tidy doesn't like #[something="something"]; it wants spaces around the =.

@jdm jdm added S-fails-tidy and removed S-tests-failed labels Mar 30, 2016
@nox
Copy link
Member Author

nox commented Mar 30, 2016

@jdm Damn.

@nox nox force-pushed the nox:devtools-serde branch from 6657355 to 406273c Mar 31, 2016
@nox
Copy link
Member Author

nox commented Mar 31, 2016

@bors-servo r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

📌 Commit 406273c has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

Testing commit 406273c with merge 3c00aff...

bors-servo added a commit that referenced this pull request Mar 31, 2016
Use serde in devtools

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10285)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

@bors-servo bors-servo merged commit 406273c into servo:master Mar 31, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.