Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude square brackets for IPv6 addresses in Document::domain. #10287
Conversation
The specification changed out from under us. It's unfortunately impossible to write a test for this right now.
highfive
commented
Mar 30, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 30, 2016
|
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 30, 2016
Include square brackets for IPv6 addresses in Document::domain. The specification changed out from under us. It's unfortunately impossible to write a test for this right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10287) <!-- Reviewable:end -->
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 30, 2016
Include square brackets for IPv6 addresses in Document::domain. The specification changed out from under us. It's unfortunately impossible to write a test for this right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10287) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
Mar 31, 2016
Include square brackets for IPv6 addresses in Document::domain. The specification changed out from under us. It's unfortunately impossible to write a test for this right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10287) <!-- Reviewable:end -->
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedMar 30, 2016
The specification changed out from under us.
It's unfortunately impossible to write a test for this right now.
This change is