Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10211: Stop re-exporting webrender_traits WebGL types from canvas_traits #10291

Merged
merged 1 commit into from Mar 31, 2016
Merged

#10211: Stop re-exporting webrender_traits WebGL types from canvas_traits #10291

merged 1 commit into from Mar 31, 2016

Conversation

@jfhumann
Copy link
Contributor

jfhumann commented Mar 30, 2016

This change is Reviewable
@highfive
Copy link

highfive commented Mar 30, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.
@highfive
Copy link

highfive commented Mar 30, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/lib.rs, components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webgltexture.rs, components/script/dom/bindings/trace.rs, components/script/dom/webglprogram.rs, components/script/dom/webglrenderbuffer.rs, components/script/dom/webglbuffer.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs, components/script/dom/webgltexture.rs, components/script/dom/webglprogram.rs, components/script/dom/webglrenderbuffer.rs, components/script/dom/webglbuffer.rs
@highfive
Copy link

highfive commented Mar 30, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jfhumann
#10211: Stop re-exporting webrender_traits WebGL types from canvas_tr…
Loading status checks…
d778562 
…aits
@jfhumann jfhumann force-pushed the jfhumann:10211 branch from ec8a28e to d778562 Mar 30, 2016
@emilio
Copy link
Member

emilio commented Mar 30, 2016

@bors-servo: r+

Thanks! :)
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit d778562 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

⌛ Testing commit d778562 with merge 524a004...
bors-servo added a commit that referenced this pull request Mar 31, 2016
@bors-servo
Auto merge of #10291 - jfhumann:10211, r=emilio
Loading status checks…
524a004 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10291)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit d778562 into servo:master Mar 31, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Mar 31, 2016
Merged
Merged
@jfhumann jfhumann deleted the jfhumann:10211 branch Mar 31, 2016
@cbrewster cbrewster mentioned this pull request Apr 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jfhumann @highfive @emilio @bors-servo
You can’t perform that action at this time.